e38fc319dc
* Change account and user fabricators to simplify and improve tests - `Fabricate(:account)` implicitly fabricates an associated `user` if no `domain` attribute is given (an account with `domain: nil` is considered a local account, but no user record was created), unless `user: nil` is passed - `Fabricate(:account, user: Fabricate(:user))` should still be possible but is discouraged. * Fix and refactor tests - avoid passing unneeded attributes to `Fabricate(:user)` or `Fabricate(:account)` - avoid embedding `Fabricate(:user)` into a `Fabricate(:account)` or the other way around - prefer `Fabricate(:user, account_attributes: …)` to `Fabricate(:user, account: Fabricate(:account, …)` - also, some tests were using remote accounts with local user records, which is not representative of production code.
82 lines
2.5 KiB
Ruby
82 lines
2.5 KiB
Ruby
require 'rails_helper'
|
|
|
|
RSpec.describe Api::V1::Statuses::FavouritedByAccountsController, type: :controller do
|
|
render_views
|
|
|
|
let(:user) { Fabricate(:user) }
|
|
let(:app) { Fabricate(:application, name: 'Test app', website: 'http://testapp.com') }
|
|
let(:token) { Fabricate(:accessible_access_token, resource_owner_id: user.id, application: app, scopes: 'read:accounts') }
|
|
let(:alice) { Fabricate(:account) }
|
|
let(:bob) { Fabricate(:account) }
|
|
|
|
context 'with an oauth token' do
|
|
before do
|
|
allow(controller).to receive(:doorkeeper_token) { token }
|
|
end
|
|
|
|
describe 'GET #index' do
|
|
let(:status) { Fabricate(:status, account: user.account) }
|
|
|
|
before do
|
|
Favourite.create!(account: alice, status: status)
|
|
Favourite.create!(account: bob, status: status)
|
|
end
|
|
|
|
it 'returns http success' do
|
|
get :index, params: { status_id: status.id, limit: 2 }
|
|
expect(response).to have_http_status(200)
|
|
expect(response.headers['Link'].links.size).to eq(2)
|
|
end
|
|
|
|
it 'returns accounts who favorited the status' do
|
|
get :index, params: { status_id: status.id, limit: 2 }
|
|
expect(body_as_json.size).to eq 2
|
|
expect([body_as_json[0][:id], body_as_json[1][:id]]).to match_array([alice.id.to_s, bob.id.to_s])
|
|
end
|
|
|
|
it 'does not return blocked users' do
|
|
user.account.block!(bob)
|
|
get :index, params: { status_id: status.id, limit: 2 }
|
|
expect(body_as_json.size).to eq 1
|
|
expect(body_as_json[0][:id]).to eq alice.id.to_s
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'without an oauth token' do
|
|
before do
|
|
allow(controller).to receive(:doorkeeper_token) { nil }
|
|
end
|
|
|
|
context 'with a private status' do
|
|
let(:status) { Fabricate(:status, account: user.account, visibility: :private) }
|
|
|
|
describe 'GET #index' do
|
|
before do
|
|
Fabricate(:favourite, status: status)
|
|
end
|
|
|
|
it 'returns http unautharized' do
|
|
get :index, params: { status_id: status.id }
|
|
expect(response).to have_http_status(404)
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'with a public status' do
|
|
let(:status) { Fabricate(:status, account: user.account, visibility: :public) }
|
|
|
|
describe 'GET #index' do
|
|
before do
|
|
Fabricate(:favourite, status: status)
|
|
end
|
|
|
|
it 'returns http success' do
|
|
get :index, params: { status_id: status.id }
|
|
expect(response).to have_http_status(200)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|